netdev - Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 27 Feb 2018 15:46:09 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH net-next 0/5] Modernize bitbanged GPIO MDIO

On 02/27/2018 03:10 PM, Andrew Lunn wrote:
>> Nack on patches 1 and 3, because I am slowly resuming work on an x86
>> platform driver that uses the mdio-gpio driver with platform data, and
>> DT is not an option there, and I would rather not have to revert your
>> changes.
> 
> Hi Florian
> 
> Would it be O.K. to change the platform_data to use a gpio descriptor,
> rather than gpio number and active_low flag? That would simplify a lot
> of code.

Oh absolutely, the move towards gpio descriptors is entirely fine and
reasonable, it was just the plain removal of platform_data instantiation
that I am objecting to. Thanks!
-- 
Florian