netdev - Re: [PATCH] tcp: Support tcp socket allocated counter in namespace.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 09:41:47 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] tcp: Support tcp socket allocated counter in namespace.

From: Tonghao Zhang <xiangxia.m.yue@...il.com>
Date: Wed, 28 Feb 2018 21:01:52 +0800

>> The amount of new conditional tests in these fast paths are not
>> justified for this new counter which is of debatable usefullness.
> sorry, too late for reply. Did you mean this counter will affect performance ?
> I tested the patch witch netperf.

A single flow TCP session with no loss doesn't tell us much.

I just know from how these things go that under load, and with
all kinds of different flows with different characterstics,
every conditional test in the fast paths matter.

If you want to have a chance at your change getting accepted,
running all kinds of benchmarks won't do it.

Instead, please find a way to make your feature work without all of
the newly added tests (whilst not adding another cost at the same
time).

Thank you.