netdev - Re: [PATCH 4/6] net: make skb_gso_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 10:53:53 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dja@...ens.net
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] net: make skb_gso_*_seglen functions private

From: Daniel Axtens <dja@...ens.net>
Date: Wed, 28 Feb 2018 00:04:05 +1100

> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 0c0c1d6f28ef..a664a3ae507e 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -4893,7 +4893,7 @@ EXPORT_SYMBOL_GPL(skb_scrub_packet);
>   *
>   * The MAC/L2 or network (IP, IPv6) headers are not accounted for.
>   */
> -unsigned int skb_gso_transport_seglen(const struct sk_buff *skb)
> +static inline unsigned int skb_gso_transport_seglen(const struct sk_buff *skb)
 ...
> +static inline unsigned int skb_gso_network_seglen(const struct sk_buff *skb)
 ...
> +static inline unsigned int skb_gso_mac_seglen(const struct sk_buff *skb)

Please drop the inline keyword.  Functions in foo.c files should not be
marked inline, let the compiler decide whether it's beneficial to
inline or not.