netdev - Re: [PATCH net-next v2] ipvlan: use per device spinlock to protect addrs list updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 28 Feb 2018 12:20:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     pabeni@...hat.com
Cc:     netdev@...r.kernel.org, maheshb@...gle.com, jbenc@...hat.com
Subject: Re: [PATCH net-next v2] ipvlan: use per device spinlock to protect
 addrs list updates

From: Paolo Abeni <pabeni@...hat.com>
Date: Wed, 28 Feb 2018 10:59:27 +0100

> This changeset moves ipvlan address under RCU protection, using
> a per ipvlan device spinlock to protect list mutation and RCU
> read access to protect list traversal.
> 
> Also explicitly use RCU read lock to traverse the per port
> ipvlans list, so that we can now perform a full address lookup
> without asserting the RTNL lock.
> 
> Overall this allows the ipvlan driver to check fully for duplicate
> addresses - before this commit ipv6 addresses assigned by autoconf
> via prefix delegation where accepted without any check - and avoid
> the following rntl assertion failure still in the same code path:
 ...
>  v1 -> v2: drop unneeded in_softirq check in ipvlan_addr6_validator_event()
> 
> Fixes: e9997c2938b2 ("ipvlan: fix check for IP addresses in control path")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>

Nice work, thanks for tackling this locking problem.

Applied.