lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 28 Feb 2018 22:15:40 -0500 From: Neal Cardwell <ncardwell@...gle.com> To: Eric Dumazet <edumazet@...gle.com> Cc: "David S . Miller" <davem@...emloft.net>, netdev <netdev@...r.kernel.org>, Yuchung Cheng <ycheng@...gle.com>, Soheil Hassas Yeganeh <soheil@...gle.com>, Eric Dumazet <eric.dumazet@...il.com> Subject: Re: [PATCH net-next 1/2] tcp_bbr: better deal with suboptimal GSO (II) On Wed, Feb 28, 2018 at 5:40 PM, Eric Dumazet <edumazet@...gle.com> wrote: > > This is second part of dealing with suboptimal device gso parameters. > In first patch (350c9f484bde "tcp_bbr: better deal with suboptimal GSO") > we dealt with devices having low gso_max_segs > > Some devices lower gso_max_size from 64KB to 16 KB (r8152 is an example) > > In order to probe an optimal cwnd, we want BBR being not sensitive > to whatever GSO constraint a device can have. > > This patch removes tso_segs_goal() CC callback in favor of > min_tso_segs() for CC wanting to override sysctl_tcp_min_tso_segs > > Next patch will remove bbr->tso_segs_goal since it does not have > to be persistent. > > Signed-off-by: Eric Dumazet <edumazet@...gle.com> > --- Acked-by: Neal Cardwell <ncardwell@...gle.com> Looks great to me. Thanks, Eric! neal
Powered by blists - more mailing lists