netdev - RE: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx FIFO on port 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 4 Mar 2018 09:33:01 +0000
From:   Stefan Chulski <stefanc@...vell.com>
To:     Thomas Petazzoni <thomas.petazzoni@...tlin.com>
CC:     Antoine Tenart <antoine.tenart@...tlin.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Yan Markman <ymarkman@...vell.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "maxime.chevallier@...tlin.com" <maxime.chevallier@...tlin.com>,
        "gregory.clement@...tlin.com" <gregory.clement@...tlin.com>,
        "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        Nadav Haklai <nadavh@...vell.com>,
        "mw@...ihalf.com" <mw@...ihalf.com>
Subject: RE: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx
 FIFO on port 0



> -----Original Message-----
> From: Thomas Petazzoni [mailto:thomas.petazzoni@...tlin.com]
> Sent: Sunday, March 04, 2018 11:25 AM
> To: Stefan Chulski <stefanc@...vell.com>
> Cc: Antoine Tenart <antoine.tenart@...tlin.com>; davem@...emloft.net;
> Yan Markman <ymarkman@...vell.com>; netdev@...r.kernel.org; linux-
> kernel@...r.kernel.org; maxime.chevallier@...tlin.com;
> gregory.clement@...tlin.com; miquel.raynal@...tlin.com; Nadav Haklai
> <nadavh@...vell.com>; mw@...ihalf.com
> Subject: Re: [PATCH net-next 3/5] net: mvpp2: use a data size of 10kB for Tx
> FIFO on port 0
> 
> Hello,
> 
> On Sun, 4 Mar 2018 06:29:59 +0000, Stefan Chulski wrote:
> 
> > > Is there a reason to hardcode 10KB for port 0, and 3KB for the other ports
> ?
> > > Would there be use cases where the user may want different
> > > configurations ?
> >
> > Design requirement are 10KB TX FIFO for the 10Gb/sec and 2.5KB for the
> 2.5Gb/sec.
> 
> What is a "design requirement" ? Is it a HW design limitation ?

We can call it HW design limitation. Anyway to support 10Gb/sec port should have at least 10KB TX FIFO.

> So, the limitation has nothing to do with CP110 really, it's just a limitation of
> PPv2.2, and mentioning CP110 in the comment doesn't make much sense,
> correct ?

I will change it.

Stefan.