netdev - Re: [for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Mar 2018 14:07:14 -0700
From:   Jason Gunthorpe <jgg@...lanox.com>
To:     Saeed Mahameed <saeedm@...lanox.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Doug Ledford <dledford@...hat.com>, netdev@...r.kernel.org,
        linux-rdma@...r.kernel.org, Leon Romanovsky <leonro@...lanox.com>,
        Aviad Yehezkel <aviadye@...lanox.com>,
        Matan Barak <matanb@...lanox.com>,
        Boris Pismenny <borisp@...lanox.com>
Subject: Re: [for-next 09/14] {net,IB}/mlx5: Add has_tag to mlx5_flow_act

On Mon, Mar 05, 2018 at 12:46:32PM -0800, Saeed Mahameed wrote:
> From: Matan Barak <matanb@...lanox.com>
> 
> The has_tag member will indicate whether a tag action was specified
> in flow specification.

It would be good to describe in the commit message why

 flow_act.flow_tag != MLX5_FS_DEFAULT_FLOW_TAG

isn't good enough anymore.

> Signed-off-by: Matan Barak <matanb@...lanox.com>
> Reviewed-by: Aviad Yehezkel <aviadye@...lanox.com>
> Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
>  drivers/infiniband/hw/mlx5/main.c                 | 3 ++-
>  drivers/net/ethernet/mellanox/mlx5/core/en_tc.c   | 1 +
>  drivers/net/ethernet/mellanox/mlx5/core/fs_core.c | 2 +-
>  include/linux/mlx5/fs.h                           | 1 +
>  4 files changed, 5 insertions(+), 2 deletions(-)

Assuming there is a good reason to do this:

Acked-by: Jason Gunthorpe <jgg@...lanox.com>

Jason