lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 05 Mar 2018 10:23:39 -0500 (EST) From: David Miller <davem@...emloft.net> To: felix.manlunas@...ium.com Cc: netdev@...r.kernel.org, raghu.vatsavayi@...ium.com, derek.chickles@...ium.com, satananda.burla@...ium.com, intiyaz.basha@...ium.com Subject: Re: [PATCH net-next] liquidio: Added ndo_get_phys_port_id support From: Felix Manlunas <felix.manlunas@...ium.com> Date: Fri, 2 Mar 2018 18:59:10 -0800 > Added support to the ndo_get_phys_port_id() callback to provide > port specific unique id to the netdev layer. > > Port id needs to be unique across different liquidio devices in the system. > So used MAC address for port_id. This doesn't look right at all. The physical port ID is used in order to distinguish several netdev devices present on the same PHYSICAL PORT. So you should be using a number that is unique within a physical port. Using the MAC address for this doesn't make any sense at all.
Powered by blists - more mailing lists