netdev - Re: [PATCH net] test_rhashtable: Add missing rcu_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 8 Mar 2018 23:58:38 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Paul Blakey <paulb@...lanox.com>
Cc:     Thomas Graf <tgraf@...g.ch>, David Miller <davem@...emloft.net>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] test_rhashtable: Add missing rcu_read_lock()

On Thu, Mar 08, 2018 at 01:54:57PM +0200, Paul Blakey wrote:
> Suppress "suspicious rcu_dereference_protected() usage!" on duplicate
> insertion test.
> 
> Fixes: 499ac3b60f65 ('test_rhashtable: add test case for rhl_table with duplicate objects')
> Signed-off-by: Paul Blakey <paulb@...lanox.com>

This shouldn't be doing a table walk in the first place.

You should convert it to using the table walk interface.

Direct table walks are forbidden because they will break when
you hit a resize.

Cheers,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt