netdev - Re: [PATCH net] team: Fix double free in error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Mar 2018 11:20:46 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     arkadis@...lanox.com
Cc:     netdev@...r.kernel.org, mlxsw@...lanox.com, jiri@...nulli.us
Subject: Re: [PATCH net] team: Fix double free in error path

From: Arkadi Sharshevsky <arkadis@...lanox.com>
Date: Thu,  8 Mar 2018 12:42:10 +0200

> The __send_and_alloc_skb() receives a skb ptr as a parameter but in
> case it fails the skb is not valid:
> - Send failed and released the skb internally.
> - Allocation failed.
> 
> The current code tries to release the skb in case of failure which
> causes redundant freeing.
> 
> Fixes: 9b00cf2d1024 ("team: implement multipart netlink messages for options transfers")
> Signed-off-by: Arkadi Sharshevsky <arkadis@...lanox.com>
> Acked-by: Jiri Pirko <jiri@...lanox.com>

Indeed, all of the team send functions call down into either multicast
or unicast netlink sends, which either free or consume the SKB.

Applied and queued up for -stable, thanks.