netdev - Re: [PATCHv2 net-next] openvswitch: fix vport packet length check.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 08 Mar 2018 12:50:48 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     u9012063@...il.com
Cc:     netdev@...r.kernel.org, pshelar@....org, jbenc@...hat.com
Subject: Re: [PATCHv2 net-next] openvswitch: fix vport packet length check.

From: William Tu <u9012063@...il.com>
Date: Wed,  7 Mar 2018 15:38:48 -0800

> When sending a packet to a tunnel device, the dev's hard_header_len
> could be larger than the skb->len in function packet_length().
> In the case of ip6gretap/erspan, hard_header_len = LL_MAX_HEADER + t_hlen,
> which is around 180, and an ARP packet sent to this tunnel has
> skb->len = 42.  This causes the 'unsign int length' to become super
> large because it is negative value, causing the later ovs_vport_send
> to drop it due to over-mtu size.  The patch fixes it by setting it to 0.
> 
> Signed-off-by: William Tu <u9012063@...il.com>
> ---
> v1->v2:
>   replace the return type from unsigned int to int

Applied, thanks.