netdev - Re: [PATCH net v2] openvswitch: meter: fix the incorrect calculation of max delta

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 10 Mar 2018 14:06:27 -0800
From:   Pravin Shelar <pshelar@....org>
To:     zhangliping <zhanglkk1990@....com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>,
        zhangliping <zhangliping02@...du.com>, Andy Zhou <azhou@....org>
Subject: Re: [PATCH net v2] openvswitch: meter: fix the incorrect calculation
 of max delta_t

On Thu, Mar 8, 2018 at 6:08 PM, zhangliping <zhanglkk1990@....com> wrote:
> From: zhangliping <zhangliping02@...du.com>
>
> Max delat_t should be the full_bucket/rate instead of the full_bucket.
> Also report EINVAL if the rate is zero.
>
> Fixes: 96fbc13d7e77 ("openvswitch: Add meter infrastructure")
> Cc: Andy Zhou <azhou@....org>
> Signed-off-by: zhangliping <zhangliping02@...du.com>
> ---
>  V2: report EINVAL if the rate is 0 to avoid divide by zero error.
>

Looks good.

Acked-by: Pravin B Shelar <pshelar@....org>