netdev - Re: [PATCH net 4/7] net: aquantia: Add aq_tx_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 16 Mar 2018 14:51:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     igor.russkikh@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com
Subject: Re: [PATCH net 4/7] net: aquantia: Add aq_tx_clean_budget and
 valid budget handling logic

From: Igor Russkikh <igor.russkikh@...antia.com>
Date: Fri, 16 Mar 2018 13:53:47 +0300

> diff --git a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> index ebbaf63..5723f2c 100644
> --- a/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> +++ b/drivers/net/ethernet/aquantia/atlantic/aq_nic.c
> @@ -36,6 +36,10 @@ static unsigned int aq_itr_rx;
>  module_param_named(aq_itr_rx, aq_itr_rx, uint, 0644);
>  MODULE_PARM_DESC(aq_itr_rx, "RX interrupt throttle rate");
>  
> +unsigned aq_tx_clean_budget = 256;
> +module_param_named(aq_tx_clean_budget, aq_tx_clean_budget, uint, 0644);
> +MODULE_PARM_DESC(aq_tx_clean_budget, "Maximum descriptors to cleanup on TX at once");
> +
>  static void aq_nic_update_ndev_stats(struct aq_nic_s *self);

Please do not add driver private module parameter knobs like this.

Instead, please use a existing, device agnostic, runtime,
configuration mechanism to control this.

Thank you.