netdev - Re: [PATCH 1/2] brcmfmac: add new dt entries for SG SDIO settings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 18 Mar 2018 21:01:26 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Alexey Roslyakov <alexey.roslyakov@...il.com>
Cc:     kvalo@...eaurora.org, robh+dt@...nel.org, mark.rutland@....com,
        arend.vanspriel@...adcom.com, franky.lin@...adcom.com,
        hante.meuleman@...adcom.com, chi-hsien.lin@...ress.com,
        wright.feng@...ress.com, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com,
        brcm80211-dev-list@...ress.com
Subject: Re: [PATCH 1/2] brcmfmac: add new dt entries for SG SDIO settings

> +	if (of_property_read_u16(np, "brcm,sd-head-align", &align) == 0)
> +		sdio->sd_head_align = align;

Hi Alexey

I think you can make this:

	of_property_read_u16(np, "brcm,sd-head-align", &sdio->sd_head_align);

of_property_read_u16() should not touch the destination variable if
the properties does not exist, or if there is an error.

    Andrew