netdev - Re: [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 14:14:31 -0400
From:   Roman Mashak <mrv@...atatu.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us
Subject: Re: [PATCH iproute2 1/1] tc: fix conversion types when printing actions unsigned values

Stephen Hemminger <stephen@...workplumber.org> writes:

> On Mon, 19 Mar 2018 13:50:07 -0400
> Roman Mashak <mrv@...atatu.com> wrote:
>
>> Signed-off-by: Roman Mashak <mrv@...atatu.com>
>> ---
>>  tc/m_action.c     | 2 +-
>>  tc/m_gact.c       | 2 +-
>>  tc/m_ife.c        | 2 +-
>>  tc/m_pedit.c      | 2 +-
>>  tc/m_sample.c     | 6 +++---
>>  tc/m_tunnel_key.c | 2 +-
>>  6 files changed, 8 insertions(+), 8 deletions(-)
>> 
>> diff --git a/tc/m_action.c b/tc/m_action.c
>> index 148f1372d414..85c9d44c7e50 100644
>> --- a/tc/m_action.c
>> +++ b/tc/m_action.c
>> @@ -408,7 +408,7 @@ int print_action(const struct sockaddr_nl *who,
>>  	if (tb[TCA_ROOT_COUNT])
>>  		tot_acts = RTA_DATA(tb[TCA_ROOT_COUNT]);
>>  
>> -	fprintf(fp, "total acts %d\n", tot_acts ? *tot_acts:0);
>> +	fprintf(fp, "total acts %u\n", tot_acts ? *tot_acts:0);
>
> Please add spaces around : in trigraph.
>
> When fixing code, it has to pass style checkers.

Thanks, I will send v2.