netdev - Re: [PATCH net 5/7] net/sched: fix idr leak in the error path of __tcf_ipt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 19 Mar 2018 12:33:15 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Davide Caratti <dcaratti@...hat.com>
Cc:     kbuild-all@...org, Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net 5/7] net/sched: fix idr leak in the error path of
 __tcf_ipt_init()

Hi Davide,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on v4.16-rc4]
[also build test ERROR on next-20180316]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Davide-Caratti/fix-idr-leak-in-actions/20180319-110101
config: i386-randconfig-x009-201811 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net/sched/act_ipt.c: In function 'tcf_ipt_release':
>> net/sched/act_ipt.c:84:11: error: 'struct tcf_ipt' has no member named 'tfci_t'; did you mean 'tcfi_t'?
     if (ipt->tfci_t) {
              ^~~~~~
              tcfi_t

vim +84 net/sched/act_ipt.c

    79	
    80	static void tcf_ipt_release(struct tc_action *a)
    81	{
    82		struct tcf_ipt *ipt = to_ipt(a);
    83	
  > 84		if (ipt->tfci_t) {
    85			ipt_destroy_target(ipt->tcfi_t);
    86			kfree(ipt->tcfi_t);
    87		}
    88		kfree(ipt->tcfi_tname);
    89	}
    90	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29796 bytes)