netdev - Re: [PATCH net-next] net/sched: act_vlan: declare push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 23 Mar 2018 21:54:24 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     dcaratti@...hat.com
Cc:     jiri@...nulli.us, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] net/sched: act_vlan: declare push_vid with
 host byte order

From: Davide Caratti <dcaratti@...hat.com>
Date: Fri, 23 Mar 2018 19:31:30 +0100

> use u16 in place of __be16 to suppress the following sparse warnings:
> 
>  net/sched/act_vlan.c:150:26: warning: incorrect type in assignment (different base types)
>  net/sched/act_vlan.c:150:26: expected restricted __be16 [usertype] push_vid
>  net/sched/act_vlan.c:150:26: got unsigned short
>  net/sched/act_vlan.c:151:21: warning: restricted __be16 degrades to integer
>  net/sched/act_vlan.c:208:26: warning: incorrect type in assignment (different base types)
>  net/sched/act_vlan.c:208:26: expected unsigned short [unsigned] [usertype] tcfv_push_vid
>  net/sched/act_vlan.c:208:26: got restricted __be16 [usertype] push_vid
> 
> Signed-off-by: Davide Caratti <dcaratti@...hat.com>

Also applied, thanks Davide.