netdev - Re: [PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell write.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 27 Mar 2018 13:12:16 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     manish.chopra@...ium.com
Cc:     netdev@...r.kernel.org, ariel.elior@...ium.com,
        michal.kalderon@...ium.com
Subject: Re: [PATCH v2 net 1/1] qede: Fix barrier usage after tx doorbell
 write.

From: Manish Chopra <manish.chopra@...ium.com>
Date: Tue, 27 Mar 2018 06:34:41 -0700

> Since commit c5ad119fb6c09b0297446be05bd66602fa564758
> ("net: sched: pfifo_fast use skb_array") driver is exposed
> to an issue where it is hitting NULL skbs while handling TX
> completions. Driver uses mmiowb() to flush the writes to the
> doorbell bar which is a write-combined bar, however on x86
> mmiowb() does not flush the write combined buffer.
> 
> This patch fixes this problem by replacing mmiowb() with wmb()
> after the write combined doorbell write so that writes are
> flushed and synchronized from more than one processor.
> 
> V1->V2:
> -------
> This patch was marked as "superseded" in patchwork.
> (Not really sure for what reason).Resending it as v2.
> 
> Signed-off-by: Ariel Elior <ariel.elior@...ium.com>
> Signed-off-by: Manish Chopra <manish.chopra@...ium.com>

Applied, thank you.