netdev - Re: ip6_forward / NF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 30 Mar 2018 09:06:52 -0600
From:   David Ahern <dsahern@...il.com>
To:     Jeff Barnhill <0xeffeff@...il.com>, netdev@...r.kernel.org
Subject: Re: ip6_forward / NF_HOOK and counters

On 3/26/18 7:35 PM, Jeff Barnhill wrote:
> At the end of ip6_forward(), is there a good reason why
> IPSTATS_MIB_OUTFORWDATAGRAMS and IPSTATS_MIB_OUTOCTETS are incremented
> before the NF_HOOK?  If the hook steals or drops the packet, this
> counts still go up, which seems incorrect.
> 
> v4/ip_forward() increments these counters in ip_forward_finish().  It
> seems that v6 should do it in ip6_forward_finish() ?? Thoughts?
> 
> Jeff
> 

I agree and think it is part of the alignment between IPv4 and IPv6.