netdev - Re: [net-next V7 PATCH 07/16] virtio_net: convert to use generic xdp_frame and xdp_return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 10:56:36 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     kbuild-all@...org, netdev@...r.kernel.org,
        BjörnTöpel <bjorn.topel@...el.com>,
        magnus.karlsson@...el.com, eugenia@...lanox.com,
        Jason Wang <jasowang@...hat.com>,
        John Fastabend <john.fastabend@...il.com>,
        Eran Ben Elisha <eranbe@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>, galp@...lanox.com,
        Daniel Borkmann <borkmann@...earbox.net>,
        Alexei Starovoitov <alexei.starovoitov@...il.com>,
        Tariq Toukan <tariqt@...lanox.com>, brouer@...hat.com
Subject: Re: [net-next V7 PATCH 07/16] virtio_net: convert to use generic
 xdp_frame and xdp_return_frame API


On Sat, 31 Mar 2018 02:22:35 +0800 kbuild test robot <lkp@...el.com> wrote:

> reproduce:
>         # apt-get install sparse
>         make ARCH=x86_64 allmodconfig
>         make C=1 CF=-D__CHECK_ENDIAN__

[...]
>    417	
>    418	static bool __virtnet_xdp_xmit(struct virtnet_info *vi,
>    419				       struct xdp_buff *xdp)
>    420	{
[...]
>    445	
>    446		/* Make room for virtqueue hdr (also change xdpf->headroom?) */
>    447		xdpf->data -= vi->hdr_len;
>    448		/* Zero header and leave csum up to XDP layers */
>    449		hdr = xdpf->data;
>    450		memset(hdr, 0, vi->hdr_len);
>  > 451		hdr->hdr.hdr_len = xdpf->len; /* Q: is this needed? */ 

I'll just remove this line, as Jason previously told me that it is not
strictly necessary (so lets avoid playing with endianness here).

>    452		xdpf->len   += vi->hdr_len;
>    453	

-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer