netdev - Re: [PATCH net-next 00/11] mlxsw: Various cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 31 Mar 2018 22:14:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     idosch@...lanox.com
Cc:     netdev@...r.kernel.org, jiri@...lanox.com, petrm@...lanox.com,
        mlxsw@...lanox.com
Subject: Re: [PATCH net-next 00/11] mlxsw: Various cleanups

From: David Miller <davem@...emloft.net>
Date: Sat, 31 Mar 2018 21:54:50 -0400 (EDT)

> From: Ido Schimmel <idosch@...lanox.com>
> Date: Thu, 29 Mar 2018 23:33:23 +0300
> 
>> The first 10 patches from Jiri perform small and unrelated cleanups. The
>> largest being the conversion of the KVD linear partitions from a list to
>> an array, which simplifies the code.
>> 
>> The last patch from Petr is a bug fix for a recent net-next commit that
>> prevented the "kvd" resource from being marked as the parent of its
>> various child resources (e.g., "/kvd/linear").
> 
> Series applied, thanks.

I'm going to have to revert this.

Changing the signature of devlink_resource_register() requires an update to
the netdevsim driver, which you didn't do.

drivers/net/netdevsim/devlink.c:121:8: error: too many arguments to function ‘devlink_resource_register’
  err = devlink_resource_register(devlink, "IPv6", (u64)-1,
        ^~~~~~~~~~~~~~~~~~~~~~~~~