netdev - Re: [PATCH iproute2-next] tc: Correct json output for actions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 Apr 2018 11:13:32 -0600
From:   David Ahern <dsahern@...il.com>
To:     Yuval Mintz <yuvalm@...lanox.com>
Cc:     mlxsw@...lanox.com, netdev@...r.kernel.org,
        Stephen Hemminger <stephen@...workplumber.org>,
        Roman Mashak <mrv@...atatu.com>
Subject: Re: [PATCH iproute2-next] tc: Correct json output for actions

On 4/4/18 6:24 AM, Yuval Mintz wrote:
> Commit 9fd3f0b255d9 ("tc: enable json output for actions") added JSON
> support for tc-actions at the expense of breaking other use cases that
> reach tc_print_action(), as the latter don't expect the 'actions' array
> to be a new object.
> 
> Consider the following taken duringrun of tc_chain.sh selftest,
> and see the latter command output is broken:
> 
> $ ./tc/tc -j -p actions list action gact | grep -C 3 actions
> [ {
>         "total acts": 1
>     },{
>         "actions": [ {
>                 "order": 0,
> 
> $ ./tc/tc -p -j -s filter show dev enp3s0np2 ingress | grep -C 3 actions
>             },
>             "skip_hw": true,
>             "not_in_hw": true,{
>                 "actions": [ {
>                         "order": 1,
>                         "kind": "gact",
>                         "control_action": {
> 
> Relocate the open/close of the JSON object to declare the object only
> for the case that needs it.
> 
> Signed-off-by: Yuval Mintz <yuvalm@...lanox.com>
> ---
>  tc/m_action.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)


This is a bug fix so it should go through master.

Added Roman so he is aware of the mistake.