lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 5 Apr 2018 16:05:51 +0200 From: Felix Fietkau <nbd@....name> To: Joe Perches <joe@...ches.com>, netdev@...r.kernel.org, linux-wireless@...r.kernel.org, b43-dev@...ts.infradead.org, bridge@...ts.linux-foundation.org, netfilter-devel@...r.kernel.org, coreteam@...filter.org Cc: linux-kernel@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, brcm80211-dev-list@...ress.com Subject: Re: [PATCH 00/12] Ethernet: Add and use ether_<type>_addr globals On 2018-04-05 15:51, Joe Perches wrote: >> You have to factor in >> not just the .text size, but the fact that referencing an exported >> symbol needs a .reloc entry as well, which also eats up some space (at >> least when the code is being built as module). > > Thanks, the modules I built got smaller. Please post some numbers to show this. By the way, on other architectures the numbers will probably be different, especially on ARM/MIPS. >> In my opinion, your series probably causes more bloat in common >> configurations instead of reducing it. >> >> You're also touching several places that could easily use >> eth_broadcast_addr and eth_zero_addr. I think making those changes would >> be more productive than what you did in this series. > > Doubtful. AFAIK: possible unaligned addresses. Those two are just memset calls, alignment does not matter. - Felix
Powered by blists - more mailing lists