netdev - Re: [PATCH] slip: Check if rstate is initialized before uncompressing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 Apr 2018 11:48:11 +0200
From:   Guillaume Nault <g.nault@...halink.fr>
To:     tejaswit@...eaurora.org
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH] slip: Check if rstate is initialized before uncompressing

On Tue, Apr 10, 2018 at 11:28:10AM +0530, tejaswit@...eaurora.org wrote:
> On 2018-04-09 20:34, David Miller wrote:
> > From: Tejaswi Tanikella <tejaswit@...eaurora.org>
> > Date: Mon, 9 Apr 2018 14:23:49 +0530
> > 
> > > @@ -673,6 +677,7 @@ struct slcompress *
> > >  	if (cs->cs_tcp.doff > 5)
> > >  	  memcpy(cs->cs_tcpopt, icp + ihl*4 + sizeof(struct tcphdr),
> > > (cs->cs_tcp.doff - 5) * 4);
> > >  	cs->cs_hsize = ihl*2 + cs->cs_tcp.doff*2;
> > > +	cs->initialized = 1;
> > >  	/* Put headers back on packet
> >  ...
> > >  struct cstate {
> > >  	byte_t	cs_this;	/* connection id number (xmit) */
> > > +	byte_t	initialized;	/* non-zero if initialized */
> > 
> > Please use 'bool' and true/false for 'initialized'.
> 
> Made the changes.

Hi Tejaswi,

Please send the new version of your patch as fresh new submission, with
proper subject prefix. In this case, it should be [PATCH net v2]. 'net'
because this is a bugfix and it should therefore target the 'net' tree.
'v2' because that's the second version of this series.

Also it'd be good if you could add a proper 'Fixes' tag in order to
help with stable backports. If the bug has always been there, just say
so.

I have no expertise on slhc, but overall, the patch content looks fine.

Guillaume