lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 12 Apr 2018 15:18:43 +0100 From: Phil Elwell <phil@...pberrypi.org> To: Andrew Lunn <andrew@...n.ch> Cc: Woojung Huh <woojung.huh@...rochip.com>, Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>, Rob Herring <robh+dt@...nel.org>, Mark Rutland <mark.rutland@....com>, "David S. Miller" <davem@...emloft.net>, Mauro Carvalho Chehab <mchehab@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Linus Walleij <linus.walleij@...aro.org>, Andrew Morton <akpm@...ux-foundation.org>, Randy Dunlap <rdunlap@...radead.org>, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org Subject: Re: [PATCH 1/4] lan78xx: Read MAC address from DT if present Hi Andrew, On 12/04/2018 15:06, Andrew Lunn wrote: > Hi Phil > >> - ret = lan78xx_write_reg(dev, RX_ADDRL, addr_lo); >> - ret = lan78xx_write_reg(dev, RX_ADDRH, addr_hi); >> + mac_addr = of_get_mac_address(dev->udev->dev.of_node); > > It might be better to use the higher level eth_platform_get_mac_address(). OK - I'll take your word for it. Phil
Powered by blists - more mailing lists