lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 Apr 2018 13:26:23 -0600 From: David Ahern <dsahern@...il.com> To: David Miller <davem@...emloft.net> Cc: netdev@...r.kernel.org, idosch@...sch.org, roopa@...ulusnetworks.com, eric.dumazet@...il.com, weiwan@...gle.com, kafai@...com, yoshfuji@...ux-ipv6.org Subject: Re: [PATCH net-next 07/21] net/ipv6: Save route type in rt6_info On 4/16/18 1:20 PM, David Miller wrote: > From: David Ahern <dsahern@...il.com> > Date: Mon, 16 Apr 2018 08:22:41 -0700 > >> @@ -2394,6 +2395,7 @@ static void addrconf_add_mroute(struct net_device *dev) >> .fc_ifindex = dev->ifindex, >> .fc_dst_len = 8, >> .fc_flags = RTF_UP, >> + .fc_type = RTN_UNICAST, >> .fc_nlinfo.nl_net = dev_net(dev), >> }; >> > > Multicast route is of type RTN_UNICAST? The ff00::/8 route is. Today's code: # ip -d -6 ro ls table local .. unicast ff00::/8 dev eth3 proto boot scope global metric 256 pref medium unicast ff00::/8 dev eth4 proto boot scope global metric 256 pref medium With this patch set: # ip -d -6 ro ls table local ... unicast ff00::/8 dev eth3 proto boot scope global metric 256 pref medium unicast ff00::/8 dev eth4 proto boot scope global metric 256 pref medium > > All of these cases where passing in a zero initialized value of > fc_type up until this patch. Perhaps you should discuss that in your > commit message a little bit. ok
Powered by blists - more mailing lists