netdev - Re: [PATCH bpf-next 2/9] bpf: add bpf_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 18 Apr 2018 21:49:27 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Yonghong Song <yhs@...com>
Cc:     kbuild-all@...org, ast@...com, daniel@...earbox.net,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH bpf-next 2/9] bpf: add bpf_get_stack helper

Hi Yonghong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Yonghong-Song/bpf-add-bpf_get_stack-helper/20180418-210810
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   kernel/bpf/core.c: In function 'bpf_prog_free_deferred':
>> kernel/bpf/core.c:1714:3: error: implicit declaration of function 'put_callchain_buffers' [-Werror=implicit-function-declaration]
      put_callchain_buffers();
      ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +/put_callchain_buffers +1714 kernel/bpf/core.c

  1704	
  1705	static void bpf_prog_free_deferred(struct work_struct *work)
  1706	{
  1707		struct bpf_prog_aux *aux;
  1708		int i;
  1709	
  1710		aux = container_of(work, struct bpf_prog_aux, work);
  1711		if (bpf_prog_is_dev_bound(aux))
  1712			bpf_prog_offload_destroy(aux->prog);
  1713		if (aux->prog->need_callchain_buf)
> 1714			put_callchain_buffers();
  1715		for (i = 0; i < aux->func_cnt; i++)
  1716			bpf_jit_free(aux->func[i]);
  1717		if (aux->func_cnt) {
  1718			kfree(aux->func);
  1719			bpf_prog_unlock_free(aux->prog);
  1720		} else {
  1721			bpf_jit_free(aux->prog);
  1722		}
  1723	}
  1724	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (49847 bytes)