netdev - Re: [PATCH] r8169: don't use netif_info et al before net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 Apr 2018 11:59:51 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH] r8169: don't use netif_info et al before net_device
 has been registered

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 22 Apr 2018 17:15:15 +0200

> There's no benefit in using netif_info et al before the net_device has
> been registered. We get messages like
> r8169 0000:03:00.0 (unnamed net_device) (uninitialized): [message]
> Therefore use dev_info/dev_err instead.
> 
> As a side effect we don't need parameter dev for function
> rtl8169_get_mac_version() any longer.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Please properly tag your Subject lines with the tree you are targetting,
in this case it should have been "[PATCH net-next]"

Applied, thank you.