netdev - Re: [PATCH 1/1] Revert "rds: ib: add error handle"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 24 Apr 2018 13:25:08 +0200
From:   Dag Moxnes <dag.moxnes@...cle.com>
To:     Håkon Bugge <haakon.bugge@...cle.com>,
        Santosh Shilimkar <santosh.shilimkar@...cle.com>
Cc:     Zhu Yanjun <yanjun.zhu@...cle.com>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        rds-devel@....oracle.com, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] Revert "rds: ib: add error handle"

I was going to suggest the following correction:


If all agree that this is the correct way of doing it, I can go ahead 
and an post it.

Regards,

-Dag


On 04/24/2018 01:10 PM, Håkon Bugge wrote:
>
>> On 24 Apr 2018, at 05:27, santosh.shilimkar@...cle.com wrote:
>>
>> On 4/23/18 6:39 PM, Zhu Yanjun wrote:
>>> This reverts commit 3b12f73a5c2977153f28a224392fd4729b50d1dc.
>>> After long time discussion and investigations, it seems that there
>>> is no mem leak. So this patch is reverted.
>>> Signed-off-by: Zhu Yanjun <yanjun.zhu@...cle.com>
>>> ---
>> Well your fix was not for any leaks but just proper labels for
>> graceful exits. I don't know which long time discussion
>> you are referring but there is no need to revert this change
>> unless you see any issue with your change.
> As spotted by Dax Moxnes, the patch misses to call rds_ib_dev_put() when exiting normally, only on err exit.
>
>
> Thxs, Håkon
>
>> Regards,
>> Santosh
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html


View attachment "0001-rds-ib-Fix-missing-call-to-rds_ib_dev_put-in-rds_ib_.patch" of type "text/x-patch" (1186 bytes)