netdev - Re: [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 27 Apr 2018 17:33:23 +0800
From:   Xin Long <lucien.xin@...il.com>
To:     Stefano Brivio <sbrivio@...hat.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Alexey Kodanev <alexey.kodanev@...cle.com>,
        Jarod Wilson <jarod@...hat.com>,
        Sabrina Dubroca <sd@...asysnail.net>,
        network dev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] selftests: pmtu: Minimum MTU for vti6 is 68

On Fri, Apr 27, 2018 at 1:41 AM, Stefano Brivio <sbrivio@...hat.com> wrote:
> A vti6 interface can carry IPv4 packets too.
>
> Signed-off-by: Stefano Brivio <sbrivio@...hat.com>
> ---
>  tools/testing/selftests/net/pmtu.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh
> index 1e428781a625..7651fd4d86fe 100755
> --- a/tools/testing/selftests/net/pmtu.sh
> +++ b/tools/testing/selftests/net/pmtu.sh
> @@ -368,7 +368,7 @@ test_pmtu_vti6_link_add_mtu() {
>
>         fail=0
>
> -       min=1280
> +       min=68                  # vti6 can carry IPv4 packets too
>         max=$((65535 - 40))
>         # Check invalid values first
>         for v in $((min - 1)) $((max + 1)); do
> @@ -384,7 +384,7 @@ test_pmtu_vti6_link_add_mtu() {
>         done
>
>         # Now check valid values
> -       for v in 1280 1300 $((65535 - 40)); do
> +       for v in 68 1280 1300 $((65535 - 40)); do
>                 ${ns_a} ip link add vti6_a mtu ${v} type vti6 local ${veth6_a_addr} remote ${veth6_b_addr} key 10
>                 mtu="$(link_get_mtu "${ns_a}" vti6_a)"
>                 ${ns_a} ip link del vti6_a
> --
> 2.15.1
>
Reviewed-by: Xin Long <lucien.xin@...il.com>