netdev - Re: [PATCH net] net/tls: Don't recursively call push_record during tls_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 01 May 2018 19:02:57 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     davejwatson@...com
Cc:     andre@...t.net, netdev@...r.kernel.org, borisp@...lanox.com,
        aviadye@...lanox.com
Subject: Re: [PATCH net] net/tls: Don't recursively call push_record during
 tls_write_space callbacks

From: Dave Watson <davejwatson@...com>
Date: Tue, 1 May 2018 13:05:39 -0700

> It is reported that in some cases, write_space may be called in
> do_tcp_sendpages, such that we recursively invoke do_tcp_sendpages again:
> 
> [  660.468802]  ? do_tcp_sendpages+0x8d/0x580
> [  660.468826]  ? tls_push_sg+0x74/0x130 [tls]
> [  660.468852]  ? tls_push_record+0x24a/0x390 [tls]
> [  660.468880]  ? tls_write_space+0x6a/0x80 [tls]
> ...
> 
> tls_push_sg already does a loop over all sending sg's, so ignore
> any tls_write_space notifications until we are done sending.
> We then have to call the previous write_space to wake up
> poll() waiters after we are done with the send loop.
> 
> Reported-by: Andre Tomt <andre@...t.net>
> Signed-off-by: Dave Watson <davejwatson@...com>

Applied.