netdev - Re: [PATCH net] tcp: restore autocorking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 May 2018 14:06:06 +0300
From:   Tariq Toukan <tariqt@...lanox.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>,
        Tal Gilboa <talgi@...lanox.com>
Cc:     netdev <netdev@...r.kernel.org>, Michael Wenig <mwenig@...are.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net] tcp: restore autocorking



On 03/05/2018 6:25 AM, Eric Dumazet wrote:
> When adding rb-tree for TCP retransmit queue, we inadvertently broke
> TCP autocorking.
> 
> tcp_should_autocork() should really check if the rtx queue is not empty.
> 

Hi Eric,

We are glad to see that the issue that Tal investigated and reported [1] 
is now addressed.
Thanks for doing that!

Tal, let’s perf test to see the effect of this fix.

Best,
Tariq

[1] https://patchwork.ozlabs.org/cover/822218/