netdev - Re: [PATCH net] net: dsa: mv88e6xxx: Fix PHY interrupts by parameterising PHY base address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 07 May 2018 23:42:44 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org, vivien.didelot@...oirfairelinux.com
Subject: Re: [PATCH net] net: dsa: mv88e6xxx: Fix PHY interrupts by
 parameterising PHY base address

From: Andrew Lunn <andrew@...n.ch>
Date: Sat,  5 May 2018 20:58:22 +0200

> Most of the mv88e6xxx switches have the PHYs at address 0, 1, 2, ...
> The 6341 however has the PHYs at 0x10, 0x11, 0x12. Add a parameter to
> the info structure for this base address.
> 
> Testing of 6f88284f3bd7 ("net: dsa: mv88e6xxx: Add MDIO interrupts for
> internal PHYs") was performed on the 6341. So it works only on the
> 6341. Use this base information to correctly set the interrupt.
> 
> Fixes: 6f88284f3bd7 ("net: dsa: mv88e6xxx: Add MDIO interrupts for internal PHYs")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Applied to 'net'.

> This is a rather big patch for net, but it is simple. What it is
> fixing is also not too big an issue. Since the interrupt number is in
> the wrong place, phylib does not find it, and so does polling. So i
> would understand if this goes to net-next, not net.

It's 'big' but simple.