lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 8 May 2018 13:44:39 +0800 From: Sun Lianwen <sunlw.fnst@...fujitsu.com> To: <rdunlap@...radead.org>, <viro@...iv.linux.org.uk> CC: <netdev@...r.kernel.org> Subject: Re: [PATCH] net/9p: correct some comment errors in 9p file system code On 05/08/2018 12:51 PM, Randy Dunlap wrote: > On 05/07/2018 06:49 PM, Sun Lianwen wrote: >> There are follow comment errors: >> 1 The function name is wrong in p9_release_pages() comment. >> 2 The function name and variable name is wrong in p9_poll_workfn() comment. >> 3 There is no variable dm_mr and lkey in struct p9_trans_rdma. >> 4 The function name is wrong in rdma_create_trans() comment. >> 5 There is no variable initialized in struct virtio_chan. >> 6 The variable name is wrong in p9_virtio_zc_request() comment. >> >> Signed-off-by: Sun Lianwen <sunlw.fnst@...fujitsu.com> >> Reviewed-by: Randy Dunlap <rdunlap@...radead.org> > > Uh, you aren't supposed to add that (line above) until or unless I offer it. > See Documentation/process/submitting-patches.rst for details. > I am very sorry about this. I am new hand on commit patch, something I need to study. thanks for forgiving my mistake. > >> --- >> net/9p/trans_common.c | 2 +- >> net/9p/trans_fd.c | 4 ++-- >> net/9p/trans_rdma.c | 4 +--- >> net/9p/trans_virtio.c | 5 ++--- >> 4 files changed, 6 insertions(+), 9 deletions(-) > > > > > Reviewed-by: Randy Dunlap <rdunlap@...radead.org> > > thanks, > Kind regards, Sun Lianwen
Powered by blists - more mailing lists