netdev - Re: [PATCH net] ipv4: fix memory leaks in udp_sendmsg, ping_v4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 11 May 2018 12:01:41 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     rdna@...com
Cc:     netdev@...r.kernel.org, ast@...nel.org, eric.dumazet@...il.com,
        kernel-team@...com
Subject: Re: [PATCH net] ipv4: fix memory leaks in udp_sendmsg,
 ping_v4_sendmsg

From: Andrey Ignatov <rdna@...com>
Date: Thu, 10 May 2018 10:59:34 -0700

> Fix more memory leaks in ip_cmsg_send() callers. Part of them were fixed
> earlier in 919483096bfe.
> 
> * udp_sendmsg one was there since the beginning when linux sources were
>   first added to git;
> * ping_v4_sendmsg one was copy/pasted in c319b4d76b9e.
> 
> Whenever return happens in udp_sendmsg() or ping_v4_sendmsg() IP options
> have to be freed if they were allocated previously.
> 
> Add label so that future callers (if any) can use it instead of kfree()
> before return that is easy to forget.
> 
> Fixes: c319b4d76b9e (net: ipv4: add IPPROTO_ICMP socket kind)
> Signed-off-by: Andrey Ignatov <rdna@...com>

Applied and queued up for -stable, thank you.