netdev - Re: [PATCH net] net/ipv4: Initialize proto and ports in flow struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 16 May 2018 12:48:07 -0600
From:   David Ahern <dsahern@...il.com>
To:     netdev@...r.kernel.org
Cc:     roopa@...ulusnetworks.com
Subject: Re: [PATCH net] net/ipv4: Initialize proto and ports in flow struct

On 5/16/18 12:18 PM, David Ahern wrote:

> @@ -347,8 +348,11 @@ static int __fib_validate_source(struct sk_buff *skb, __be32 src, __be32 dst,
>  	no_addr = idev->ifa_list == NULL;
>  
>  	fl4.flowi4_mark = IN_DEV_SRC_VMARK(idev) ? skb->mark : 0;
> -
> -	trace_fib_validate_source(dev, &fl4);

Looks like I sent the net-next version; did not mean to remove that
tracepoint in net. Will send v2


> +	if (!fib4_rules_early_flow_dissect(net, skb, &fl4, &flkeys)) {
> +		fl4.flowi4_proto = 0;
> +		fl4.fl4_sport = 0;
> +		fl4.fl4_dport = 0;
> +	}
>  
>  	if (fib_lookup(net, &fl4, &res, 0))
>  		goto last_resort;