netdev - Re: [PATCH v2 net-next 3/6] tcp: add SACK compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 May 2018 13:41:21 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>,
        "David S . Miller" <davem@...emloft.net>
Cc:     netdev <netdev@...r.kernel.org>,
        Toke Høiland-Jørgensen 
        <toke@...e.dk>, Neal Cardwell <ncardwell@...gle.com>,
        Yuchung Cheng <ycheng@...gle.com>,
        Soheil Hassas Yeganeh <soheil@...gle.com>,
        Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH v2 net-next 3/6] tcp: add SACK compression



On 05/17/2018 10:47 AM, Eric Dumazet wrote:

> +	/* compress ack timer : 5 % of srtt, but no more than 1 ms */
> +
> +	delay = min_t(unsigned long, NSEC_PER_MSEC,
> +		      tp->rcv_rtt_est.rtt_us * (NSEC_PER_USEC >> 3)/20);
>

Yuchung suggested that we use min(rtt, rcv_rtt), and I totally agree with him.

I will send a v3 with this suggestion.