netdev - Re: [net-next] i40iw/i40e: Remove link dependency on i40e

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 08:03:44 -0700
From:   Alexander Duyck <alexander.duyck@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
        Jason Gunthorpe <jgg@...lanox.com>,
        David Miller <davem@...emloft.net>,
        Doug Ledford <dledford@...hat.com>,
        Sindhu Devale <sindhu.devale@...el.com>,
        Netdev <netdev@...r.kernel.org>, linux-rdma@...r.kernel.org,
        Neil Horman <nhorman@...hat.com>,
        Stefan Assmann <sassmann@...hat.com>,
        John Greene <jogreene@...hat.com>,
        Shiraz Saleem <shiraz.saleem@...el.com>
Subject: Re: [net-next] i40iw/i40e: Remove link dependency on i40e

On Tue, May 22, 2018 at 11:19 PM, Christoph Hellwig <hch@...radead.org> wrote:
> On Tue, May 22, 2018 at 02:04:06PM -0700, Jeff Kirsher wrote:
>> > Why would you want to do this? The rdma driver is non-functional
>> > without the ethernet driver, so why on earth would we want to defeat
>> > the module dependency mechanism?
>>
>> This change is driven by the OSV's like Red Hat, where customer's were
>> updating the i40e driver, which in turn broke i40iw.
>
> Doctor it hurts when I do this..
>
> There is no reason to make a mess of our drivers because people are
> doing things they should haver never done and that aren't supported
> in Linux.
>
> If Intel didn;t offer any out of tree drivers I'm pretty sure no
> customer would even attempt this.  So fix this where the problem is.

Are you serious? You are never going to see out-of-tree drivers go
away. They exist for the simple reason that most customers/OSVs are
slow to upgrade their kernels so we have people running on a 3.10
something kernel on their RHEL 7.X and want to use the latest greatest
hardware.

I find it ridiculous that you expect us to support a product with
in-kernel only and it is pretty short sighted to insist that that is
the only way to support a product.

With that said it probably wouldn't hurt to throw a WARN_ONCE in here
somewhere that basically informs the user they are doing something
stupid and essentially disabling the i40iw driver if they remove i40e.

- Alex