netdev - Re: [PATCH net] net/mlx4: Fix irq-unsafe spinlock usage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 23 May 2018 15:49:37 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     tariqt@...lanox.com
Cc:     netdev@...r.kernel.org, eranbe@...lanox.com,
        jackm@....mellanox.co.il
Subject: Re: [PATCH net] net/mlx4: Fix irq-unsafe spinlock usage

From: Tariq Toukan <tariqt@...lanox.com>
Date: Wed, 23 May 2018 10:41:59 +0300

> From: Jack Morgenstein <jackm@....mellanox.co.il>
> 
> spin_lock/unlock was used instead of spin_un/lock_irq
> in a procedure used in process space, on a spinlock
> which can be grabbed in an interrupt.
> 
> This caused the stack trace below to be displayed (on kernel
> 4.17.0-rc1 compiled with Lock Debugging enabled):
 ...
> Since mlx4_qp_lookup() is called only in process space, we can
> simply replace the spin_un/lock calls with spin_un/lock_irq calls.
> 
> Fixes: 6dc06c08bef1 ("net/mlx4: Fix the check in attaching steering rules")
> Signed-off-by: Jack Morgenstein <jackm@....mellanox.co.il>
> Signed-off-by: Tariq Toukan <tariqt@...lanox.com>
> ---
> 
> Hi Dave, please queue for -stable >= 4.12.

Applied and queued up for -stable, thanks.