netdev - Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 14:50:31 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     mhabets@...arflare.com
Cc:     linux-net-drivers@...arflare.com, netdev@...r.kernel.org,
        jarod@...hat.com
Subject: Re: [PATCH v2 net-next] sfc: stop the TX queue before pushing new
 buffers

From: Martin Habets <mhabets@...arflare.com>
Date: Thu, 24 May 2018 10:14:00 +0100

> efx_enqueue_skb() can push new buffers for the xmit_more functionality.
> We must stops the TX queue before this or else the TX queue does not get
> restarted and we get a netdev watchdog.
> 
> In the error handling we may now need to unwind more than 1 packet, and
> we may need to push the new buffers onto the partner queue.
> 
> v2: In the error leg also push this queue if xmit_more is set
> 
> Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
> Reported-by: Jarod Wilson <jarod@...hat.com>
> Tested-by: Jarod Wilson <jarod@...hat.com>
> Signed-off-by: Martin Habets <mhabets@...arflare.com>
> ---
> 
> Dave, could you please also queue this patch up for stable?

Applied to net-next.

As per -stable, only patches that go into my 'net' tree may be proposed
for -stable.