netdev - Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 May 2018 14:13:40 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Sven Eckelmann <sven@...fation.org>
Cc:     Simon Wunderlich <sw@...onwunderlich.de>, davem@...emloft.net,
        netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
        Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/8] batman-adv: Disable CONFIG_BATMAN_ADV_DEBUGFS by
 default

On 5/25/2018 1:50 PM, Sven Eckelmann wrote:

> [...]
>>> --- a/net/batman-adv/Kconfig
>>> +++ b/net/batman-adv/Kconfig
>>> @@ -94,13 +94,13 @@ config BATMAN_ADV_DEBUGFS
>>> bool "batman-adv debugfs entries"
>>> depends on BATMAN_ADV
>>> depends on DEBUG_FS
>>> -       default y
>>> +       default n
>>
>>      N is the default default. :-) You don't need this line.
> 
> Hm, looks like this would have to be changed in a lot of places (~782
> according to `git grep 'default n$'|wc -l` in my slightly outdated linux-
> next). Do you want to fix it everywhere?

    No, but we can at least not add the new ones...

> Might be good to get this integrated
> in checkpatch.pl when this will become a new policy.

    Adding Joe Perches. Joe, can you add a check for "default n"?

> Kind regards,
> 	Sven

MBR, Sergei