lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 26 May 2018 00:22:18 -0700 From: "Samudrala, Sridhar" <sridhar.samudrala@...el.com> To: Stephen Hemminger <stephen@...workplumber.org> Cc: mst@...hat.com, davem@...emloft.net, netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org, virtio-dev@...ts.oasis-open.org, jesse.brandeburg@...el.com, alexander.h.duyck@...el.com, kubakici@...pl, jasowang@...hat.com, loseweigh@...il.com, jiri@...nulli.us, aaron.f.brown@...el.com, anjali.singhai@...el.com Subject: Re: [PATCH net-next v12 2/5] netvsc: refactor notifier/event handling code to use the failover framework On 5/25/2018 4:28 PM, Stephen Hemminger wrote: > On Fri, 25 May 2018 16:11:47 -0700 > "Samudrala, Sridhar" <sridhar.samudrala@...el.com> wrote: > >> On 5/25/2018 3:34 PM, Stephen Hemminger wrote: >>> On Thu, 24 May 2018 09:55:14 -0700 >>> Sridhar Samudrala <sridhar.samudrala@...el.com> wrote: >>> >>>> --- a/drivers/net/hyperv/Kconfig >>>> +++ b/drivers/net/hyperv/Kconfig >>>> @@ -2,5 +2,6 @@ config HYPERV_NET >>>> tristate "Microsoft Hyper-V virtual network driver" >>>> depends on HYPERV >>>> select UCS2_STRING >>>> + select FAILOVER >>> When I take a working kernel config, add the patches then do >>> make oldconfig >>> >>> It is not autoselecting FAILOVER, it prompts me for it. This means >>> if user says no then a non-working netvsc device is made. >> I see >> Generic failover module (FAILOVER) [M/y/?] (NEW) >> >> So the user is given an option to either build as a Module or part of the >> kernel. 'n' is not an option. > With most libraries there is no prompt at all. Not sure what you meant by this. Without any patches applied, i had a .config file with HYPERV_NET configured as a module. Then after applying the first 2 patches in this series, i did a make oldconfig and i see the above prompt. Are you saying that on some distros, 'make oldconfig creates a .config file without any prompt and FAILOVER is not getting selected even when HYPERV_NET is enabled?
Powered by blists - more mailing lists