netdev - Re: Missing skb->dst with flow offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 May 2018 20:30:03 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     Felix Fietkau <nbd@....name>, netfilter-devel@...r.kernel.org,
        Netdev <netdev@...r.kernel.org>, openwrt-devel@...ts.openwrt.org,
        Jaap Buurman <jaapbuurman@...il.com>,
        WireGuard mailing list <wireguard@...ts.zx2c4.com>
Subject: Re: Missing skb->dst with flow offloading

On Wed, May 30, 2018 at 8:24 PM, Pablo Neira Ayuso <pablo@...filter.org> wrote:
> May it crash the kernel because it's assuming is set? If so, then
> I'd appreciate if you send us a patch to

I suspect it won't crash, but the pmtu might wind up wrong / not calculated.

> Please, use the nf-next.git tree to patch nf_flow_offload_ip_hook()
> and nf_flow_offload_ip6_hook(), it's rather late, we'll request a
> -stable submission for this if needed.

Given the above, I'll submit a patch, though I don't suppose it will
be necessary for -stable.