lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 31 May 2018 10:05:49 +0800 From: Jason Wang <jasowang@...hat.com> To: Wei Yongjun <weiyongjun1@...wei.com>, "Michael S. Tsirkin" <mst@...hat.com>, Sridhar Samudrala <sridhar.samudrala@...el.com> Cc: virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org, kernel-janitors@...r.kernel.org Subject: Re: [PATCH net-next] virtio_net: fix error return code in virtnet_probe() On 2018年05月31日 10:05, Wei Yongjun wrote: > Fix to return a negative error code from the failover create fail error > handling case instead of 0, as done elsewhere in this function. > > Fixes: ba5e4426e80e ("virtio_net: Extend virtio to use VF datapath when available") > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com> > --- > drivers/net/virtio_net.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > index 8f08a3e..2d55e2a 100644 > --- a/drivers/net/virtio_net.c > +++ b/drivers/net/virtio_net.c > @@ -2935,8 +2935,10 @@ static int virtnet_probe(struct virtio_device *vdev) > > if (virtio_has_feature(vdev, VIRTIO_NET_F_STANDBY)) { > vi->failover = net_failover_create(vi->dev); > - if (IS_ERR(vi->failover)) > + if (IS_ERR(vi->failover)) { > + err = PTR_ERR(vi->failover); > goto free_vqs; > + } > } > > err = register_netdev(dev); > Acked-by: Jason Wang <jasowang@...hat.com>
Powered by blists - more mailing lists