netdev - Re: [PATCH] bnx2x: use the right constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 06 Jun 2018 14:01:35 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     Julia.Lawall@...6.fr
Cc:     ariel.elior@...ium.com, kernel-janitors@...r.kernel.org,
        everest-linux-l2@...ium.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2x: use the right constant

From: Julia Lawall <Julia.Lawall@...6.fr>
Date: Wed,  6 Jun 2018 15:03:22 +0200

> Nearby code that also tests port suggests that the P0 constant should be
> used when port is zero.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression e,e1;
> @@
> 
> * e ? e1 : e1
> // </smpl>
> 
> Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx")
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

This definitely looks correct.  Applied and queued up for -stable, thanks!