netdev - RE: [PATCH ethtool 2/6] ethtool: fix RING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 8 Jun 2018 15:20:06 +0000
From:   "Keller, Jacob E" <jacob.e.keller@...el.com>
To:     Ivan Vecera <cera@...a.cz>,
        "linville@...driver.com" <linville@...driver.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH ethtool 2/6] ethtool: fix RING_VF assignment

> -----Original Message-----
> From: Ivan Vecera [mailto:cera@...a.cz]
> Sent: Friday, June 08, 2018 2:20 AM
> To: linville@...driver.com
> Cc: netdev@...r.kernel.org; Keller, Jacob E <jacob.e.keller@...el.com>
> Subject: [PATCH ethtool 2/6] ethtool: fix RING_VF assignment
> 
> Fixes: 36ee712 ("ethtool: support queue and VF fields for rxclass filters")
> Cc: Jacob Keller <jacob.e.keller@...el.com>
> Signed-off-by: Ivan Vecera <cera@...a.cz>
> ---
>  rxclass.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/rxclass.c b/rxclass.c
> index ce4b382..42d122d 100644
> --- a/rxclass.c
> +++ b/rxclass.c
> @@ -1066,7 +1066,7 @@ static int rxclass_get_val(char *str, unsigned char *p,
> u32 *flags,
>  		val++;
> 
>  		*(u64 *)&p[opt->offset] &=
> ~ETHTOOL_RX_FLOW_SPEC_RING_VF;
> -		*(u64 *)&p[opt->offset] = (u64)val <<
> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF;
> +		*(u64 *)&p[opt->offset] |= (u64)val <<
> ETHTOOL_RX_FLOW_SPEC_RING_VF_OFF;
>  		break;
>  	}

Hah. Good catch.

Thanks,
Jake

>  	case OPT_RING_QUEUE: {
> --
> 2.16.4