netdev - Re: [PATCH net] net: aquantia: fix unsigned numvecs comparison with less than zero

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 08 Jun 2018 18:46:44 -0400 (EDT)
From:   David Miller <davem@...emloft.net>
To:     igor.russkikh@...antia.com
Cc:     netdev@...r.kernel.org, darcari@...hat.com,
        pavel.belous@...antia.com, colin.king@...onical.com
Subject: Re: [PATCH net] net: aquantia: fix unsigned numvecs comparison
 with less than zero

From: Igor Russkikh <igor.russkikh@...antia.com>
Date: Thu,  7 Jun 2018 17:54:37 -0400

> From: Colin Ian King <colin.king@...onical.com>
> 
> From: Colin Ian King <colin.king@...onical.com>
> 
> This was originally mistakenly submitted to net-next. Resubmitting to net.
> 
> The comparison of numvecs < 0 is always false because numvecs is a u32
> and hence the error return from a failed call to pci_alloc_irq_vectores
> is never detected.  Fix this by using the signed int ret to handle the
> error return and assign numvecs to err.
> 
> Detected by CoverityScan, CID#1468650 ("Unsigned compared against 0")
> 
> Fixes: a09bd81b5413 ("net: aquantia: Limit number of vectors to actually allocated irqs")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> Signed-off-by: Igor Russkikh <igor.russkikh@...antia.com>

Applied and queued up for -stable, thanks.