lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 13 Jun 2018 09:51:10 -0700
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Tejaswi Tanikella <tejaswit@...eaurora.org>,
        Andrew Lunn <andrew@...n.ch>
Cc:     netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH 2/2] ktime: helpers to convert between ktime and jiffies

On 06/13/2018 06:35 AM, Tejaswi Tanikella wrote:
> On Tue, Jun 12, 2018 at 06:30:32PM +0200, Andrew Lunn wrote:
>> On Mon, Jun 11, 2018 at 05:22:28PM +0530, Tejaswi Tanikella wrote:
>>> Signed-off-by: Tejaswi Tanikella <tejaswit@...eaurora.org>
>>> ---
>>>  include/linux/ktime.h | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/include/linux/ktime.h b/include/linux/ktime.h
>>> index 5b9fddb..4881483 100644
>>> --- a/include/linux/ktime.h
>>> +++ b/include/linux/ktime.h
>>> @@ -96,6 +96,10 @@ static inline ktime_t timeval_to_ktime(struct timeval tv)
>>>  /* Convert ktime_t to nanoseconds - NOP in the scalar storage format: */
>>>  #define ktime_to_ns(kt)			(kt)
>>>  
>>> +/* ktime to jiffies and back */
>>> +#define ktime_to_jiffies(kt)		nsecs_to_jiffies(kt)
>>> +#define jiffies_to_ktime(j)		jiffies_to_nsecs(j)
>>
>> Hi Tejaswi
>>
>> You should also add some users of these new helpers.
>>
>>     Andrew
> 
> Hi Andrew,
> 
> I used them in the first patch.

Therefore you must swap the order of the patches in order not to break
bisectability (that is, each commit must build on its own).

Thanks!--
Florian

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux - Powered by OpenVZ