netdev - Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 19 Jun 2018 07:59:30 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Jason Gunthorpe <jgg@...pe.ca>
Cc:     Doug Ledford <dledford@...hat.com>,
        RDMA mailing list <linux-rdma@...r.kernel.org>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Matan Barak <matanb@...lanox.com>,
        Yishai Hadas <yishaih@...lanox.com>,
        Saeed Mahameed <saeedm@...lanox.com>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next v2 00/20] Introduce mlx5 DEVX interface

On Mon, Jun 18, 2018 at 04:05:04PM -0600, Jason Gunthorpe wrote:
> On Sun, Jun 17, 2018 at 12:59:46PM +0300, Leon Romanovsky wrote:
>
> > Leon Romanovsky (2):
> >   drm/i915: Move u64-to-ptr helpers to general header
> >   kernel.h: Reuse u64_to_ptr macro to cast __user pointers
>
> I dropped these since they are not needed by this series when using a
> union.

No problem, it was my idea to reuse existing macro, before it was
hard-coded implementation, but union makes it cleaner.

>
> > Matan Barak (5):
> >   IB/uverbs: Export uverbs idr and fd types
> >   IB/uverbs: Add PTR_IN attributes that are allocated/copied
> >     automatically
>
> Revised this one, as noted

Thanks

>
> >   IB/uverbs: Add a macro to define a type with no kernel known size
> >   IB/uverbs: Allow an empty namespace in ioctl() framework
> >   IB/uverbs: Refactor uverbs_finalize_objects
>
> I put the above in a branch and can apply them if you ack my revisions..
>

Except the line "return (void *)attr;", which should be "return ERR_CAST(attr);"
everything looks reasonable. I didn't test it, but I'm not worried, we will have
enough time to fix if needed.

> >   net/mlx5_core: Prevent warns in dmesg upon firmware commands
> >   IB/core: Improve uverbs_cleanup_ucontext algorithm
>
> I dropped these two (they are linked), need comments addressed and
> resent.

They are linked only logically, the second patch will trigger warning
which is suppressed by first patch. So actually mlx5-net branch will have
only first patch "net/mlx5_core: Prevent warns in dmesg upon firmware commands"
and you will apply "IB/core: Improve uverbs_cleanup_ucontext algorithm" in
your rdma-next.

>
> > Yishai Hadas (13):
> >   net/mlx5: Expose DEVX ifc structures
> >   IB/mlx5: Introduce DEVX
> >   IB/core: Introduce DECLARE_UVERBS_GLOBAL_METHODS
> >   IB: Expose ib_ucontext from a given ib_uverbs_file
> >   IB/mlx5: Add support for DEVX general command
> >   IB/mlx5: Add obj create and destroy functionality
> >   IB/mlx5: Add DEVX support for modify and query commands
> >   IB/mlx5: Add support for DEVX query UAR
> >   IB/mlx5: Add DEVX support for memory registration
> >   IB/mlx5: Add DEVX query EQN support
> >   IB/mlx5: Expose DEVX tree
>
> I put these in a branch also and can apply them, but I need the first
> two patches in the mlx5 core branch first please, thanks.
>
> Since this requires so many core patches I think I prefer to merge the
> mlx core branch then apply rather merge a branch.

So to summarize, I'm applying those three patches to mlx5-next:
 * net/mlx5_core: Prevent warns in dmesg upon firmware commands
 * net/mlx5: Expose DEVX ifc structures
 * IB/mlx5: Introduce DEVX

And resend:
 * IB/core: Improve uverbs_cleanup_ucontext algorithm

Thanks

>
> Jason

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)