lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 27 Jun 2018 11:49:49 +0200 From: Daniel Borkmann <daniel@...earbox.net> To: Jakub Kicinski <jakub.kicinski@...ronome.com>, davem@...emloft.net, jbenc@...hat.com Cc: Roopa Prabhu <roopa@...ulusnetworks.com>, jiri@...nulli.us, jhs@...atatu.com, xiyou.wangcong@...il.com, oss-drivers@...ronome.com, netdev@...r.kernel.org, Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com> Subject: Re: [PATCH net-next v2 3/4] net: check tunnel option type in tunnel flags On 06/27/2018 06:39 AM, Jakub Kicinski wrote: > From: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com> > > Check the tunnel option type stored in tunnel flags when creating options > for tunnels. Thereby ensuring we do not set geneve, vxlan or erspan tunnel > options on interfaces that are not associated with them. > > Make sure all users of the infrastructure set correct flags, for the BPF > helper we have to set all bits to keep backward compatibility. > > Signed-off-by: Pieter Jansen van Vuuren <pieter.jansenvanvuuren@...ronome.com> > Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com> > --- > CC: Daniel Borkmann <daniel@...earbox.net> > > v2: > - use __be16 for dst_opt_type in net/openvswitch/flow_netlink.c (build bot). Looks good to me, and yes in BPF case a mask like TUNNEL_OPTIONS_PRESENT is right approach since this is opaque info and solely defined by the BPF prog that is using the generic helper. Thanks, Daniel
Powered by blists - more mailing lists